Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type declarations for @analytics/segment #247

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add type declarations for @analytics/segment #247

wants to merge 2 commits into from

Conversation

VitorLuizC
Copy link

I've written the type declarations file for @analytics/segment plugin and included analytics as peerDependencies, because its AnalyticsPlugin type is used. I've also removed README.md from the "files" array in package.json because it's always included by npm, like the LICENSE file.

@VitorLuizC
Copy link
Author

@DavidWells if you prefer I can move these type declarations to @types (https://github.com/DefinitelyTyped/DefinitelyTyped) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VitorLuizC