Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' #1

Closed
wants to merge 1 commit into from
Closed

[pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' #1

wants to merge 1 commit into from

Conversation

DavidZagury
Copy link
Owner

@DavidZagury DavidZagury commented Jul 4, 2021 •
edited
Loading

Description

Resolves issue - sonic-net/sonic-buildimage#7993

  • Fixes wrong log line when Pcie module does not exists that causes the pcied daemon to enter FATAL state.
  • Change log level of line "Failed to load platform Pcie module" to notice since this is not an error flow, this is part of the normal loading flow we expect when a vendor didn't supply a Pcie class.

Motivation and Context

How Has This Been Tested?

Load image, check pcied daemon status.

Additional Information (Optional)

@DavidZagury DavidZagury changed the title [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self… [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' Jul 4, 2021
BasimShalata
BasimShalata approved these changes Jul 4, 2021
View reviewed changes
Copy link

@BasimShalata BasimShalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BasimShalata BasimShalata BasimShalata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidZagury @BasimShalata