Improve log information when exception is caught in Orch2 class #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add the information regarding which class the exception is originated from when Orch2 catches an exception.
Why I did it
An Exception was thrown:
ERR swss#orchagent: :- doTask: Logic error: map::atThis gives almost no information on where the exception happened.
How I verified it
Compiled SWSS which I forced an exception to be thrown from addOperation in VxlanTunnelOrch.
The log resulted is:
ERR swss#orchagent: :- doTask: Logic error in 15VxlanTunnelOrch: map::atWhich focus you to a specific class.
Bigger improvement would need a larger refactor.
Details if related