Fallback on "invalid" with missing translation #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `config.i18n.raise_on_missing_translations` is enabled, Rails 7.1 raises on missing translation error when validation messages are not translated, which is a new behavior causing CSV to fail For unsupported validations, like `comparison`, and custom validations, like `timeliness`, CSV attempts to create a message for a key that is not present. This commit standardizes the behavior and fallbacks on "invalid" when a translation is not found, which is supposed to be the desired behavior for this use case Close #920
tagliala
force-pushed
the
bugfix/920-fix-missing-translations
branch
from
00e297a
to
c2a360e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
config.i18n.raise_on_missing_translationsis enabled, Rails 7.1 raises on missing translation error when validation messages are not translated, which is a new behavior causing CSV to failFor unsupported validations, like
comparison, and custom validations, liketimeliness, CSV attempts to create a message for a key that is not present.This commit standardizes the behavior and fallbacks on "invalid" when a translation is not found, which is supposed to be the desired behavior for this use case
Close #920