Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night mode: be always dark #57

Open
Mikaela opened this issue Aug 28, 2015 · 9 comments
Open

Night mode: be always dark #57

Mikaela opened this issue Aug 28, 2015 · 9 comments
Assignees

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Aug 28, 2015

Some pages cause the screen to flash as white (when night mode is enabled which hurts eyes for example:

WebKit bug, I presume?

@Dax89
Copy link
Owner

Dax89 commented Aug 28, 2015

Not really a bug, but a limitation.
Night mode works by applying a custom CSS to the entire page, the problem is that it will be applied shortly after the webpage is loaded and displayed that's why you see the flashing effect.

Yes, it can be improved.
One thing that I can do is to delay the webpage rendering when night mode is enabled so the flashing effect is not visible to the user, but I don't know if this is possible

@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 29, 2015

I see. I also noticed that scrolling too much also brings the brightness.

@Dax89 Dax89 self-assigned this Aug 31, 2015
@Dax89 Dax89 closed this as completed Aug 31, 2015
@Dax89 Dax89 reopened this Aug 31, 2015
@Dax89 Dax89 closed this as completed in 86b0abe Aug 31, 2015
@Dax89
Copy link
Owner

Dax89 commented Aug 31, 2015

You can try the improved night mode with this dev package!
https://dl.dropboxusercontent.com/u/40206233/Progetti/harbour-webpirate-1.5-2.armv7hl.rpm

@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 31, 2015

Will I still get updates from store after installing or do I have to notice the updates by myself?

#54 still isn't fixed unless the fix just didn't come to that package.

Night mode seems to work better with quick testing now, but if I zoom or go further from the page (two fingers to either direction) the whiteness comes.

@Dax89
Copy link
Owner

Dax89 commented Aug 31, 2015

Mikaela
Will I still get updates from store after installing or do I have to notice the updates by myself?

Yes, because is still 1.5-x!

Mikaela
#54 still isn't fixed unless the fix just didn't come to that package.

I have fixed it in subsequent commits :)

Mikaela
Night mode seems to work better with quick testing now, but if I zoom or go further from the page (two fingers to either direction) the whiteness comes.

That's a component issue, by default, WebView's background is white.
It's just a background, probably it can be changed, I have to figure out how!
I'll reopen this request, as reminder.

I have released 1.6 in OpenRepos, you can download it from there or wait until it lands in the Harbour :)

@Dax89 Dax89 reopened this Aug 31, 2015
@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 31, 2015

Yes, because is still 1.5-x!

I see, I haven't followed version numbers so much. Odd for development even for stable? ZNC used that before.

I have released 1.6 in OpenRepos, you can download it from there or wait until it lands in the Harbour :)

I will probably wait, OpenRepos broke for me some time ago and even if I factory reset after that it's probably the best I don't use it unless I absolutely have to (Call Recorder).

@Dax89
Copy link
Owner

Dax89 commented Aug 31, 2015

I see, I haven't followed version numbers so much. Odd for development even for stable? ZNC used that before.

I'm using 1.x for the QtWebKit based browser and 2.x for the QtWebEngine one (hopefully)
Just increasing the minor version number, nothing about odd=dev, even=stable.

I will probably wait, OpenRepos broke for me some time ago and even if I factory reset after that it's probably the best I don't use it unless I absolutely have to (Call Recorder).

Ok!

@Mikaela
Copy link
Contributor Author

Mikaela commented Sep 1, 2015

Some pages also still start by loading themselves as white, I don't remember which exactly, but at least Dropbox FAQ (I was checking which ports it wants from firewall). This version is a lot better though.

@Mikaela
Copy link
Contributor Author

Mikaela commented Sep 10, 2015

mobiili.fi had large white area when started from Communi Sailfish (IRC), but it disappeared by itself after some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants