feat: upgrade to ember 3.28 #142
Conversation
GreatWizard
force-pushed
the
feat/upgrade-3-28
branch
from
2f8681a to
845e64f
Compare
GreatWizard
force-pushed
the
feat/upgrade-3-28
branch
3 times, most recently
from
6f9af8a to
5811868
Compare
GreatWizard
force-pushed
the
feat/upgrade-3-28
branch
from
5811868 to
6c017b1
Compare
GreatWizard
force-pushed
the
feat/upgrade-3-28
branch
from
6c017b1 to
55d537a
Compare
| { | ||
| name: 'ember-beta', | ||
| npm: { | ||
| devDependencies: { | ||
| 'ember-source': await getChannelURL('beta'), | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: 'ember-canary', | ||
| npm: { | ||
| devDependencies: { | ||
| 'ember-source': await getChannelURL('canary'), | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I thought we wanted, intentionally, to get rid of the scenarios beta and canary from all our Ember.js projects. (See this recent PR #141 for this project)
| { | |
| name: 'ember-beta', | |
| npm: { | |
| devDependencies: { | |
| 'ember-source': await getChannelURL('beta'), | |
| }, | |
| }, | |
| }, | |
| { | |
| name: 'ember-canary', | |
| npm: { | |
| devDependencies: { | |
| 'ember-source': await getChannelURL('canary'), | |
| }, | |
| }, | |
| }, |
There was a problem hiding this comment.
This comment is not relevant anymore, see DazzlingFugu/ember-feature-controls#153 (comment) .
| skipBabel: [ | ||
| { | ||
| package: 'qunit', | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Just to understand better, can you please explain me why this piece of code is needed? Perhaps it is automatically done when upgrading with ember-cli? Perhaps it is indicated in a migration document? Thanks ✌️ .
There was a problem hiding this comment.
IT was automatic in the upgrade tbh :) but it's for embroider testing
|
You can remove the line
from the description of your PR as it has already been done before. |
GreatWizard
force-pushed
the
feat/upgrade-3-28
branch
from
55d537a to
babd56f
Compare
Feature
Update to ember 3.28 (#142)
This PR must be considered as breaking:
Update simple-pinyin to v4 (#142)