Migrate add-on to v2 format & upgrade to Ember.js v5.4.1 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
added
dependencies
MrChocolatine
force-pushed
the
upgrade-latest-emberjs-version
branch
from
da30ca6 to
99e97f2
Compare
MrChocolatine
changed the title
MrChocolatine
force-pushed
the
upgrade-latest-emberjs-version
branch
5 times, most recently
from
c19688b to
b49a4ca
Compare
MrChocolatine
force-pushed
the
upgrade-latest-emberjs-version
branch
from
b49a4ca to
c502a06
Compare
This was referenced Nov 6, 2023
MrChocolatine
commented
Nov 6, 2023
There was a problem hiding this comment.
This folder is the test application, which is internal and not what the end users will use, so in the package.json file we don't need any of the usual information like author, description etc...
This was referenced Nov 11, 2023
MrChocolatine
changed the title
MrChocolatine
force-pushed
the
upgrade-latest-emberjs-version
branch
2 times, most recently
from
9b159a8 to
cc8e480
Compare
MrChocolatine
force-pushed
the
upgrade-latest-emberjs-version
branch
from
cc8e480 to
c64028d
Compare
MrChocolatine
force-pushed
the
upgrade-latest-emberjs-version
branch
from
c64028d to
919798b
Compare
|
We have to move forward @DazzlingFugu/emberenos , please review. |
Pixelik
approved these changes
Nov 30, 2023
MrChocolatine
changed the title
See: https://github.com/embroider-build/addon-blueprint BREAKING CHANGE: migrate add-on to v2 format & upgrade to Ember.js v5.4.0 - Now require Ember.js v4.8 or above - Now require Embroider or ember-auto-import v2
There were some warnings when running `npm publish --dry-run`: ``` ➜ npm publish --dry-run npm WARN publish npm auto-corrected some errors in your package.json when publishing. Please run "npm pkg fix" to address these errors. npm WARN publish errors corrected: npm WARN publish "repository" was changed from a string to an object npm WARN publish "repository.url" was normalized to "git+https://github.com/DazzlingFugu/ember-slugify.git" npm notice ... logs ... ```
This resolution was introduced in: #116
These are not necessary.
MrChocolatine
force-pushed
the
upgrade-latest-emberjs-version
branch
from
d3b2d5e to
9af3729
Compare
This was referenced Dec 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
Migrate add-on to v2 format (#299)
The add-on is now a full v2 add-on, it was recreated as such using Embroider and the latest specifications.
https://github.com/embroider-build/addon-blueprint
Upgrade to Ember.js v5.4.1 (#299)
ember-auto-importv2 are now requiredCloses #279 .
Below is just extra text to give more context, but it should not be included in our changelog.
Actions taken
--typescript+ v2 blueprint from EmbroiderResources
https://github.com/embroider-build/embroider/blob/main/docs/porting-addons-to-v2.md