Account for acceleration and drag #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not working perfectly just yet but it's something.
|
To me it looks like your PR changes things from working on speed and applying it to inaccuracy when you use it to working on velocity with inaccuracy baked in and including acceleration projectiles. It looks cleaner and I didn't really have a gripe with acceleration projectiles before, so I looks fine to me and I'll merge it. Side note: I'm pretty sure none of the weird stuff you posted in Discord happens without drag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the existing code while retaining the same behavior with non-accelerating projectiles, plus an accounting for accelerating projectiles.