Update Mac CI build job to handle the new targets #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more artifacts to account for there now being multiple build targets. Update brew if any of the artifacts can't be downloaded and cached. Build any artifacts that could not be downloaded and cached. Upload any artifacts that could not be downloaded and cached.
DeBlister
changed the title
DeBlister
force-pushed
the
Xcode_CompileUnitTests_UpdateBuildCI
branch
from
c114d0f
to
f5aa3d2
Compare
This reverts commit 06c9507. There should be no need to fallback from caching to fetching the framework in these workflows; the build targets should fetch it themselves.
DeBlister
force-pushed
the
Xcode_CompileUnitTests_UpdateBuildCI
branch
from
ff43418
to
0319f0b
Compare
This isn't 100% necessary but it simplifies other steps (parse and unit). Also, it does mirror the steps which building actually follows.
Use more specific names for env artifacts. Use different names for the different uploaded artifacts. Typo fix on 348. (game => unit tests)
Uploading the entire framework was simple but it took more space for 2 reasons: It packaged its dependencies with it. This is the obvious one. Both the A and Current versions for the engine itself and for its dependencies were copied, so it was something like 4x the size it really needed to be, even if the entire thing was bundled. There will have to be some more sym-linking and re-downloading the engine's dependencies but that and the storage space will now be in line with the other OS tests.
|
See this issue on the upload artifact repository describing the problem addressed in the previous commit. Due to the quadrupling effect (((versions + 1) ^ (recursive iterations)) = 2 ^ 2 = 4 in our case) brought on by the lack of sym-link support, I'm going to have to piece the engine framework back together in each of the tests for mac (parse & unit). |
Attempt to rebuild app file structure from all its pieces. This is necessary because of the previous commit which only saves the engine binary as an artifact.
6 tasks
DeBlister
force-pushed
the
Xcode_CompileUnitTests_UpdateBuildCI
branch
from
a6b8489
to
ded5c89
Compare
There shouldn't even be a B version so Current would only ever point to A; this way when reconstructing the .app file structure the Current symlink doesn't need to be created.
Test if this is necessary. Also remove the related tree line because now nothing changes between it and the one prior.
Testing is over, remove clutter.
Hopefully the options will be accepted now.
Now that test_macos-parse is done, restore its if-guard. Lower the if-guard on test_macos-unit so it can be tested.
The -v option is coded in main.cpp, which the unit tests executable obviously doesn't use.
|
Everything seems to be working now. I fixed the rpath issue by adding to the flags so that Ideally someone would review for general style and syntax before I merge this back into the main PR branch and get out of this container. |
If a variable doesn't directly reference a binary or framework (as it usually doesn't in the macos jobs) its name shouldn't imply that it does. SDL2_FRAMEWORK needs more testing to see if it can be changed like these were.
|
I'm not going to change the way SDL2_FRAMEWORK is declared because it doubles as a cache destination and a reference to the place in the repository where SDL2 is located normally. |
Everything needs to go back where it came from before merging.
Match test_macos-unit if-guard to the windows and ubuntu versions. Update the macos/Xcode path filters used by the changed job. The workspace probably shouldn't change but if it does tests should probably still run. Shared data needs to be checked, at least on the project level (this checks both project and workspace) in order to verify schemes.
DeBlister
force-pushed
the
Xcode_CompileUnitTests_UpdateBuildCI
branch
from
cd068c9
to
b53dd72
Compare
This reverts commit 010b71f. This caused issues with the game target because it has spaces in its name. The quotes could be used selectively but that would be worse than the quotes themselves.
This reverts commit 36c5706. This caused issues with the game target because it has spaces in its name. The quotes could be used selectively but that would be worse than the quotes themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing this in a PR so I can trigger actions quietly, and, hopefully, re-run them myself if I need to since this is all in my own fork.