Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Add replace-by-fee sender limit to mempool #2505

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Sep 28, 2023

Summary

  • Add replace-by-fee limit from the same sender in mempool, set to maximum of 40 replace-by-fee txs from the same sender.
  • Optimize mempool tx removal pipeline to only looping through evmTxsBySender index if the tx to be removed is an evmtx or transferdomain tx, and early return out of evmTxsBySender index if tx hash is found.
  • Add mempool tests for replace-by-fee limit from same sender.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven marked this pull request as ready for review September 28, 2023 12:14
src/txmempool.cpp Outdated Show resolved Hide resolved
@sieniven sieniven requested a review from Bushstar September 28, 2023 13:37
Bushstar
Bushstar previously approved these changes Sep 28, 2023
@prasannavl prasannavl merged commit bb38287 into master Sep 29, 2023
@prasannavl prasannavl deleted the evm/mempool-rbf-limit branch September 29, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants