Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only consolidate per-block rewards after moving to static rewards #3099

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Oct 21, 2024

Summary

  • Consolidating all rewards is no longer safe to do after the move to static rewards as rewards now have a higher precision. Consensus may generate a higher reward due to sub-satoshi amounts than more frequent intermediate running of consolidate rewards. This PR updates the -consolidatereards flag to only consolidate the per-block rewards.
  • Flush the DB after flushing the view to make sure that changes are all present in the DB.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

prasannavl
prasannavl previously approved these changes Oct 21, 2024
@Bushstar Bushstar changed the title Block consolidating rewards after static rewards Only consolidate per-block rewards after moving to static rewards Oct 21, 2024
@prasannavl prasannavl merged commit 9ee5876 into master Oct 23, 2024
17 of 28 checks passed
@prasannavl prasannavl deleted the bush/block-consolidate branch October 23, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants