Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent address for mocknet #3115

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Use consistent address for mocknet #3115

merged 1 commit into from
Nov 7, 2024

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Nov 7, 2024

Summary

  • This PR uses a fixed mocknet operator and owner masternode address for all networks. Otherwise mocknet will fail to run after the first time as the address changes was changing on each run, the first time the MN is created with a random operator and owner address, the second run the MN already exists but the randomly generated operator and owner address is different which causes an assert when trying to get the MN by operator.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit 7720b2f into master Nov 7, 2024
17 of 27 checks passed
@prasannavl prasannavl deleted the bush/mock-mn-fix branch November 7, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants