-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apps/whale-api): always return the highest yield #1978
Conversation
Code Climate has analyzed commit a2afd1e and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 91.22% // Head: 93.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
==========================================
+ Coverage 91.22% 93.84% +2.62%
==========================================
Files 368 368
Lines 10829 10825 -4
Branches 1378 1377 -1
==========================================
+ Hits 9879 10159 +280
+ Misses 908 637 -271
+ Partials 42 29 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Docker build preview for jellyfish/apps is ready! Built with commit 9883ec0
You can also get an immutable image with the commit hash
|
This reverts commit 5c44e0e.
What this PR does / why we need it:
Initially, the behavior is always to return the highest yield when doing swaps. We have updated it to use direct path first (if available) before considering other options. Even if direct path is more expensive.
This will revert it to its original behavior as some pairs are cheaper via composite swaps. (e.g, DFI -> DUSD). Will fix this issue - BirthdayResearch/defichain-wallet#3885
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: