feat(jellyfish-api-core): enable transferdomain gov attributes #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
apps/playground-api
apps/whale-api
area/apps
area/packages
labels
fullstackninja864
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
+ Coverage 92.10% 92.77% +0.66%
==========================================
Files 372 372
Lines 11201 11201
Branches 1458 1458
==========================================
+ Hits 10317 10392 +75
+ Misses 848 773 -75
Partials 36 36
... and 41 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Docker build preview for jellyfish/apps is ready! Built with commit c0a9914
You can also get an immutable image with the commit hash
|
lykalabrada
suggested changes
Aug 8, 2023
...ages/jellyfish-transaction-builder/__tests__/txn/txn_builder_account_transfer_domain.test.ts
Outdated
Show resolved
Hide resolved
pierregee
reviewed
Aug 8, 2023
packages/jellyfish-api-core/__tests__/category/account/transferDomain.test.ts
Show resolved
Hide resolved
...ages/jellyfish-transaction-builder/__tests__/txn/txn_builder_account_transfer_domain.test.ts
Outdated
Show resolved
Hide resolved
…er_account_transfer_domain.test.ts Signed-off-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com>
lykalabrada
previously approved these changes
Aug 29, 2023
packages/jellyfish-api-core/__tests__/category/account/getTokenBalances.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/transferDomain.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/transferDomain.test.ts
Show resolved
Hide resolved
|
one more req.. since we have this configuration can you add a failed case for p2sh address in transfer domain?? 🙏 |
fullstackninja864
dismissed stale reviews from lykalabrada and pierregee
via
a98ef13
packages/jellyfish-api-core/__tests__/category/account/transferDomain.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/transferDomain.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/transferDomain.test.ts
Outdated
Show resolved
Hide resolved
|
mising check p2sh addr in transferdomain via txn-builder |
…rDomain.test.ts Co-authored-by: canonbrother <w.canonbrother@gmail.com> Signed-off-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com>
…rDomain.test.ts Co-authored-by: canonbrother <w.canonbrother@gmail.com> Signed-off-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com>
here we have used p2sh address |
pierregee
previously approved these changes
Aug 30, 2023
…K/jellyfish into harsh/set-gov-transferdomain
pierregee
approved these changes
Aug 31, 2023
canonbrother
approved these changes
Aug 31, 2023
fuxingloh
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR sets gov attributes to enable EVM support for playground and added dToken transfer test caes for transfer domain
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: