Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): regression fix for master-b352814976 #2149

Merged
merged 42 commits into from
Sep 25, 2023
Merged

chore(tests): regression fix for master-b352814976 #2149

merged 42 commits into from
Sep 25, 2023

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Sep 18, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

  • deps: ethers & hardhat installed for evm stuff
  • container: add -ethrpcbind to support eth rpc call + add RUST_LOG=debug
  • CI
  • enhance checkIfEvmTx
  • fix: TD test (dftx composer, rpc & rawtx)
  • func: add ListUnspentQueryOptions to support provider listunspent method
  • fix: UpdateMN test
  • lint: ts-ignore buggy AbortController.signal type check

@netlify
Copy link

netlify bot commented Sep 18, 2023 •
edited
Loading

✅ Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 952abe9
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/650aa5252d2b9e0008ee7288
😎 Deploy Preview https://deploy-preview-2149--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@canonbrother canonbrother force-pushed the canonbrother/defichain-4.0.0-beta12 branch from 4746027 to 390a3c2 Compare September 19, 2023 01:31
@canonbrother canonbrother self-assigned this Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

Docker build preview for jellyfish/apps is ready!

Built with commit 66b0133

  • ghcr.io/birthdayresearch/legacy-api:pr-2149
  • ghcr.io/birthdayresearch/playground-api:pr-2149
  • ghcr.io/birthdayresearch/status-api:pr-2149
  • ghcr.io/birthdayresearch/whale-api:pr-2149

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:66b0133b6c0e885fe0fcec6aea47d5ecf4304f68
  • ghcr.io/birthdayresearch/playground-api:66b0133b6c0e885fe0fcec6aea47d5ecf4304f68
  • ghcr.io/birthdayresearch/status-api:66b0133b6c0e885fe0fcec6aea47d5ecf4304f68
  • ghcr.io/birthdayresearch/whale-api:66b0133b6c0e885fe0fcec6aea47d5ecf4304f68

@canonbrother canonbrother changed the title chore(tests): regression fix for master-4430349b5f chore(tests): regression fix for master-b352814976 Sep 20, 2023
@canonbrother canonbrother force-pushed the canonbrother/defichain-4.0.0-beta12 branch 3 times, most recently from 6be7aa0 to a03e285 Compare September 20, 2023 06:12
@canonbrother canonbrother force-pushed the canonbrother/defichain-4.0.0-beta12 branch from a03e285 to 952abe9 Compare September 20, 2023 07:54
@canonbrother canonbrother marked this pull request as ready for review September 20, 2023 08:38
@canonbrother
Copy link
Contributor Author

canonbrother commented Sep 20, 2023 •
edited
Loading

for own note at eb3ee72
skipping few flaky and unexpected behaviour test.. (they were passed previously)
will fix on later fixed version

fuxingloh
fuxingloh reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly skimmed through it, generally lgtm but the /dist might cause downstream usage error, should fix it

packages/jellyfish-transaction-builder/src/provider.ts Show resolved Hide resolved
@fuxingloh
Copy link
Contributor

Will merge first

@fuxingloh fuxingloh merged commit 1a2fcf4 into main Sep 25, 2023
@fuxingloh fuxingloh deleted the canonbrother/defichain-4.0.0-beta12 branch September 25, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuxingloh fuxingloh fuxingloh left review comments

@lykalabrada lykalabrada lykalabrada approved these changes

@pierregee pierregee pierregee approved these changes

@ivan-zynesis ivan-zynesis Awaiting requested review from ivan-zynesis

@eli-lim eli-lim Awaiting requested review from eli-lim

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@kyleleow kyleleow Awaiting requested review from kyleleow

Assignees

@canonbrother canonbrother

Labels
apps/whale-api area/apps area/packages area/workflow kind/chore Non feature change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@canonbrother @fuxingloh @pierregee @lykalabrada