Fix to add cpu architecture suffix to artifact name of cljstyle #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! thanks) Before merging, could you run |
|
I did not take care of the test cases. My apologies. I modified the test code as well to accommodate the logic changes and also committed the built artifacts. |
DeLaGuardo
reviewed
Jan 9, 2024
__tests__/cljstyle.test.ts
Outdated
| ${'foobar'} | ${`cljstyle_1.2.3_linux.zip`} | ||
| ${'darwin'} | ${`cljstyle_1.2.3_macos_amd64.zip`} | ||
| ${'linux'} | ${`cljstyle_1.2.3_linux_amd64.zip`} | ||
| ${'foobar'} | ${`cljstyle_1.2.3_linux_amd64.zip`} |
There was a problem hiding this comment.
could you add a test case to cover version below 0.15?
Nothing fancy, just the same test with 0.2.3 should do it
There was a problem hiding this comment.
I added a parameter to test older versions as well. Does this change deviate from your intended implementation?
DeLaGuardo
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue: #100
Thank you for maintaining a great workflow like this repository. We always appreciate your work.