Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of other actions in README example #53

Merged
merged 1 commit into from Jun 16, 2022
Merged

Update versions of other actions in README example #53

merged 1 commit into from Jun 16, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2022

I noticed that these were out of date and I figure it couldn’t hurt to
keep the ancillary aspects of the example up to date, just in case
people copy-pasta the whole example.

Speaking of which, I was also tempted to add cache: maven to
the setup-java args since it seems like a good default to me, but
I held off just to keep this change focused on one specific kind of
change. That said, I do think that’d be a good idea.

I noticed that these were out of date and I figure it couldn’t hurt to
keep the ancillary aspects of the example up to date, just in case
people copy-pasta the whole example.

Speaking of which, I was also tempted to add `cache: maven` to
the `setup-java` args since it seems like a good default to me, but
I held off just to keep this change focused on one specific kind of
change. That said, I do think that’d be a good idea.
@DeLaGuardo
Copy link
Owner

cache: maven might be good addition however it only looks at **/pom.xml which is not all the time connected with clojure-based projects. Maybe it could be a good idea to file a PR for setup-java action asking to support either custom value for cache input or add support clojure-based projects in general.

Anyway, thanks for your contribution

@DeLaGuardo DeLaGuardo merged commit 702cb0a into DeLaGuardo:master Jun 16, 2022
@ghost ghost deleted the patch-2 branch June 16, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant