Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test asset name #10

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix test asset name #10

merged 1 commit into from
Nov 7, 2023

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Test asset name (not displayed in inspector window)

Reason

  • Forgot to change

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner April 8, 2023 22:44
@github-actions github-actions bot added the fix label Apr 8, 2023
@nowsprinting
Copy link
Contributor Author

The label should be bug, but it set fix ???

@nowsprinting nowsprinting added bug Something isn't working and removed fix labels Apr 8, 2023
@nowsprinting
Copy link
Contributor Author

nowsprinting commented Apr 8, 2023 •
edited
Loading

ok, need the forked owner's name in the setting file.
Using default configuration. (see https://github.com/TimonVS/pr-labeler-action#default-configuration )
can not read config file?

@Kesin11
Copy link

Kesin11 commented Apr 10, 2023

If you turn on debug mode and re-run it, you may find the cause.

@nowsprinting
Copy link
Contributor Author

I can not re-run, it because I'm not owner!

@nowsprinting
Copy link
Contributor Author

maybe, https://github.com/TimonVS/pr-labeler-action/blob/9de3270d8cac2f0be966127f6740b04fe001f9ff/src/utils/config.ts#L31-L35

@github-actions github-actions bot added the fix label Apr 10, 2023
@Kesin11
Copy link

Kesin11 commented Apr 10, 2023 •
edited
Loading

I just re-ran with debug option, but I couldn't get anything new about pr-labeler-action behavior. 😭
https://github.com/DeNA/Anjin/actions/runs/4647465277/jobs/8238811993

@Kesin11 Kesin11 removed the fix label Apr 10, 2023
@nowsprinting
Copy link
Contributor Author

Plz wait for merge this PR:
TimonVS/pr-labeler-action#80

@Kuniwak Kuniwak self-assigned this Nov 7, 2023
Kuniwak
Kuniwak approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me. Sorry for my tooooooo late reply.

@Kuniwak Kuniwak merged commit 371859e into DeNA:master Nov 7, 2023
@nowsprinting nowsprinting deleted the fix/test_asset_name branch November 7, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuniwak Kuniwak Kuniwak approved these changes

Assignees

@Kuniwak Kuniwak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nowsprinting @Kesin11 @Kuniwak