Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not stopping and reporting when error occurred #20

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

Kuniwak
Copy link
Member

@Kuniwak Kuniwak commented Nov 9, 2023

Reproducing steps

  1. Checkout to f5eaf92
  2. Keep state not playing
  3. Open the scene "Error"
  4. Open an inspector for "AutopilotSettingsForFacingImmediatelyError"
  5. Click Run

Expected Behaviour

Stop playing and report the error to Slack.

Actual Behaviour

Still playing and did not report to Slack.


Contribution License Agreement

Reproducing steps:
1. Stay keep is not playing
2. Open the scene "Error"
3. Open an inspector for "AutopilotSettingsForFacingImmediatelyError"
4. Click Run

Expected Behaviour:
Stop playing and report the error to Slack

Actual Behaviour:
Still playing and did not report to Slack
@Kuniwak Kuniwak added the bug Something isn't working label Nov 9, 2023
@Kuniwak Kuniwak self-assigned this Nov 9, 2023
@Kuniwak Kuniwak requested a review from a team as a code owner November 9, 2023 06:37
@Kuniwak Kuniwak force-pushed the stop-when-error-immediately-thrown branch 4 times, most recently from 2da9430 to 049f935 Compare November 9, 2023 20:26
@Kuniwak Kuniwak force-pushed the stop-when-error-immediately-thrown branch from 049f935 to 9af66be Compare November 9, 2023 20:29
Base automatically changed from update-test-helper-monkey to master November 10, 2023 01:15
@Kuniwak Kuniwak merged commit 7d98f68 into master Nov 14, 2023
1 check passed
@Kuniwak Kuniwak deleted the stop-when-error-immediately-thrown branch November 14, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants