Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger using in tests #56

Merged
merged 1 commit into from
May 11, 2024
Merged

Fix logger using in tests #56

merged 1 commit into from
May 11, 2024

Conversation

nowsprinting
Copy link
Contributor

Fix conflicts #52 and #53 (both are mine...)

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner May 11, 2024 04:35
@github-actions github-actions bot added the fix label May 11, 2024
@nowsprinting
Copy link
Contributor Author

Plz change label to "chore"

@Kuniwak Kuniwak added chore and removed fix labels May 11, 2024
Kuniwak
Kuniwak approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contributions!

@Kuniwak Kuniwak merged commit b96596d into DeNA:master May 11, 2024
2 checks passed
@nowsprinting nowsprinting deleted the fix/logger_in_tests branch May 11, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuniwak Kuniwak Kuniwak approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @Kuniwak