Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing Logger instance to Monkey #58

Merged
merged 1 commit into from
May 11, 2024
Merged

Fix passing Logger instance to Monkey #58

merged 1 commit into from
May 11, 2024

Conversation

nowsprinting
Copy link
Contributor

I forgot to set a Logger instance to MonkeyConfig.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner May 11, 2024 06:19
@github-actions github-actions bot added the fix label May 11, 2024
Kuniwak
Kuniwak approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I also missed it.

@Kuniwak Kuniwak merged commit 74ed670 into DeNA:master May 11, 2024
2 checks passed
@nowsprinting nowsprinting deleted the fix/monkeyagent_logger branch May 11, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuniwak Kuniwak Kuniwak approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @Kuniwak