Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line argument -FILE_LOGGER_OUTPUT_PATH #66

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Add command line argument -FILE_LOGGER_OUTPUT_PATH #66

merged 3 commits into from
Jun 6, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Add command line argument -FILE_LOGGER_OUTPUT_PATH. Overwrite the outputPath of FileLogger
  • Fix READMEs for SlackReporter
  • Fix case of outputPath without directory
  • Fix case of outputPath is not set

Priority

It's a low priority for me.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner June 5, 2024 23:33
@github-actions github-actions bot added the fix label Jun 5, 2024
Kuniwak
Kuniwak approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kuniwak Kuniwak merged commit 3ee1bee into DeNA:master Jun 6, 2024
2 checks passed
@Kuniwak Kuniwak added the feature label Jun 6, 2024
@nowsprinting nowsprinting deleted the fix/filelogger branch June 6, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuniwak Kuniwak Kuniwak approved these changes

Assignees
No one assigned
Labels
feature fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @Kuniwak