Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does the Quantity component have an helper text? #30

Closed
1 task done
lauthieb opened this issue Jul 25, 2022 · 1 comment
Closed
1 task done

Does the Quantity component have an helper text? #30

lauthieb opened this issue Jul 25, 2022 · 1 comment
Assignees
@MARIEDELATTRE
Labels
android 🟢 Related to android bug 🐛 Something isn't working components 🧩 Related to components dev issues created ✔️ Here to say that all developers issues had been created

Comments

@lauthieb
Copy link
Member

lauthieb commented Jul 25, 2022 •
edited
Loading

Duplicates ❌

  • I have searched the existing issues

Which Figma library is concerned?

Vitamin Android UI Kit

Current behavior 😯

In Figma, the quantity component have 3 different states for the text input : normal, focus and error. In the specification, the quantity component doesn't have an helper text (in any state) but in Vitamin Web, an helper text appears when the state is in error.

Can we know if we should add too an helper text? And if we could add this helper text for all states or not?

Originally posted by @GerardPaligot.

Expected behavior 🤔

No response

Context 🔦

No response

Screenshots / Videos 📸

No response

Tasks
Beta Give feedback
  1. feat(quantity-picker): Add the error message param on Quantity Picker vitamin-compose#80
    community 👥 enhancement 🚀
    corentin-stamper
@lauthieb lauthieb added question ❓ Further information is requested android 🟢 Related to android run 💨 labels Jul 25, 2022
@GaspardMathon
Copy link
Member

FI, there is indeed a helper text for the error text in the web version of the component.

@lauthieb lauthieb changed the title Does the quantity component have an helper text? Does the Quantity component have an helper text? Oct 19, 2022
@MARIEDELATTRE MARIEDELATTRE self-assigned this Nov 9, 2022
@lauthieb lauthieb removed the question ❓ Further information is requested label Dec 19, 2022
This was referenced Jan 30, 2023
Closed
Open
@ManonPolle ManonPolle added the dev issues created ✔️ Here to say that all developers issues had been created label Jan 30, 2023
@lauthieb lauthieb added the components 🧩 Related to components label Feb 6, 2023
@lauthieb lauthieb closed this as completed Feb 9, 2023
@lauthieb lauthieb reopened this Feb 9, 2023
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MARIEDELATTRE MARIEDELATTRE

Labels
android 🟢 Related to android bug 🐛 Something isn't working components 🧩 Related to components dev issues created ✔️ Here to say that all developers issues had been created
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lauthieb @GaspardMathon @ManonPolle @MARIEDELATTRE