Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quantity-picker): Add the error message param on Quantity Picker #80

Closed
Tracked by #30
ManonPolle opened this issue Jan 30, 2023 · 0 comments · Fixed by #109
Closed
Tracked by #30

feat(quantity-picker): Add the error message param on Quantity Picker #80

ManonPolle opened this issue Jan 30, 2023 · 0 comments · Fixed by #109
Assignees
@corentin-stamper
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request
Milestone
0.3.0

Comments

@ManonPolle
Copy link
Contributor

ManonPolle commented Jan 30, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Error message has been added to Design Specificiations.
image

Describe the solution you'd like
Add optional error input param to add an error message under Quantity Picker.
Null Default value in order to have no breaking change to the component.

Additional context
Closes Decathlon/vitamin-design#30
@ManonPolle ManonPolle added enhancement 🚀 New feature or request run 💨 labels Jan 30, 2023
@corentin-stamper corentin-stamper self-assigned this Feb 3, 2023
@lauthieb lauthieb mentioned this issue Feb 6, 2023
Closed
1 task
@corentin-stamper corentin-stamper mentioned this issue Feb 9, 2023
Merged
9 tasks
@ManonPolle ManonPolle added this to the 0.3.0 milestone Mar 16, 2023
@lauthieb lauthieb added the community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community label Mar 24, 2023
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
GerardPaligot pushed a commit that referenced this issue Apr 17, 2023
@corentin-stamper
feat(quantity-pickers): Add error message label and snapshot testing (#…
3515450 
…109)

Closes #80 #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corentin-stamper corentin-stamper

Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

feat(quantity-pickers): Add error message label corentin-stamper/vitamin-compose
3 participants
@lauthieb @corentin-stamper @ManonPolle