Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spaces in file names #7

Closed
Andre601 opened this issue Jan 20, 2020 · 3 comments · Fixed by #13
Closed

Support Spaces in file names #7

Andre601 opened this issue Jan 20, 2020 · 3 comments · Fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@Andre601
Copy link

When you have files/pages that contain spaces (e.g configure bot.md) does the action treat those as separate pages and errors with the following message(s):

cp: can't stat 'wiki/configure.md': No such file or directory

The action should support spaces by f.e. replacing them with dashes (-).

@didnotwant
Copy link

didnotwant commented Apr 24, 2020

Putting spaces in filenames is not a good practice, though.

I edited my comment because I thought that your problem is similar to mine but it’s not.
But what’s related to your problem is that in this repo I could find a pull request (#10) which added a support for converting underscores _ to spaces in sidebar.


Let me connect to your thread because I think it’s not worth creating yet another one:

I have no clue why hyphens are converted to spaces in the sidebar:
e.g. filename "How-to-use.md" results in "How to use" on the list:
image

@mmornati — do you have any knowledge on this?

For now the best approach I can choose to not rely on the filename in the sidebar is to create a custom sidebar.

@mmornati
Copy link
Contributor

mmornati commented May 5, 2020

@didnotwant It is by design in GitHub wiki pages I guess: in the wiki the - are automatically converted in spaces.

@mmornati
Copy link
Contributor

mmornati commented May 5, 2020

@Andre601 I think I can try to fix problem allowing the action to take care to file with spaces... but I'm not sure what is then the result in GitHub.

@mmornati mmornati self-assigned this May 5, 2020
@mmornati mmornati added the bug Something isn't working label May 5, 2020
@mmornati mmornati linked a pull request May 5, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants