Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file with spaces #13

Merged
merged 1 commit into from
May 6, 2020
Merged

fix: file with spaces #13

merged 1 commit into from
May 6, 2020

Conversation

mmornati
Copy link
Contributor

@mmornati mmornati commented May 5, 2020

Broken Script

Why?

When file names contain spaces the copy script is broken and impossible even to ask for space replace with the _ char.

What?

Improved the loop syntax, around the find result, to take care of the correct filename, with or without spaces.
This is fixing the issue #7

@mmornati mmornati added the bug Something isn't working label May 5, 2020
@mmornati mmornati self-assigned this May 5, 2020
@mmornati mmornati linked an issue May 5, 2020 that may be closed by this pull request
Copy link
Contributor

@GregoireW GregoireW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmornati mmornati merged commit f19c6bd into master May 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_file_spaces branch May 6, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Spaces in file names
2 participants