Feature/sg 953 add XML/VOC datasets #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Dupont
changed the title
Louis-Dupont
changed the title
Louis-Dupont
commented
Jun 29, 2023
Louis-Dupont
commented
Jun 29, 2023
shaydeci
suggested changes
Jul 2, 2023
src/data_gradients/datasets/detection/voc_format_detection_dataset.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 2 datasets:
YoloFormatDetectionDatasetbut for VOC format:VOCFormatDetectionDatasetVOCDetectionDatasetI think we may need both because
VOCDetectionDatasetstructure is very heavy, and I have seen at least once in the past a dataset written in xml similarly to VOC, but with a folder naming than the PascalVOC original dataset.At the same time, I feel like it is better if we can still provide a plug-and-play class for PascalVOC where the user won't need to dig into the dataset structure.
For this reason I kept both classes. What do you think ? Is it confusing?