-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dg 979 support classification #149
Conversation
…ation' into feature/DG-979-support-classification
In SG we kept colab links rather then having the ipynb files inside the repo, I think its better that way (in case changes are introduced we will always need to update in 2 places...) |
Well I can argue that this break "atomic change" concept, that you have to make a DF release first, then go over all colab files and update them by hand. From my perspective having them under git is easier to maintain. These are meant to be "quick usage examples" that people can quickly refer to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left some comments inline but nothing too important.
As a bonus, if you can add a minimalistic end-to-end test with a dummy dataset (which can be built on the fly with random images and only a couple of random classes.
We don't have such tests for segmentation and detection but I think we should asap.
src/data_gradients/feature_extractors/classification/class_distribution.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/classification/class_distribution.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/classification/class_distribution.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor comments
src/data_gradients/assets/html/basic_info_fe_classification.html
Outdated
Show resolved
Hide resolved
…ome unknown mean/std
…ation' into feature/DG-979-support-classification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: We agreed on adressing the changes concerning the denormalization in a following RP |
ask_user
method to use ipython widgets instead of stdin when launched from notebook to allow users to provide input