Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/dg 000 fix empty batch detection #160

Merged
merged 6 commits into from
Jul 13, 2023
Merged

Hotfix/dg 000 fix empty batch detection #160

merged 6 commits into from
Jul 13, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Jul 13, 2023 •
edited
Loading

Small fix in DG which can break the detection pipeline under the combination of 3 factors:

  1. Working with batches
  2. One batch does not include any target
  3. The empty label does not respect the expected format (e.g. tensor([], size=(BS, 0)) instead of tensor([], size=(BS, 0, 5)))

@Louis-Dupont Louis-Dupont marked this pull request as ready for review July 13, 2023 10:34
ofrimasad
ofrimasad approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 12c9d90 into master Jul 13, 2023
@ofrimasad ofrimasad deleted the hotfix/DG-000-fix_empty_batch_detection branch July 13, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Louis-Dupont @ofrimasad