Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 945 move summary before adding adapter #167

Merged

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Jul 18, 2023

What was changed

The core here is to replace in the DataConfig use_cache with

    cache_filename: Optional[str] = None
    cache_dir: Optional[str] = None

AND to load the cache on instantiation.
This requires some minor logic changes but None of them should affect users in anyway.

Motivation

Currently, the cache from DataConfig is loaded by the AnalysisManager, i.e. after instantiation. And it is the AnalysisManager that provides the path to the cache.
We want to be able to load it easily on instantiation, in order to be able to load and use it directly anywhere, and not just from within the AnalysisManager

shaydeci
shaydeci previously approved these changes Aug 7, 2023
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit fa67cc1 into master Aug 7, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-945-move_summary_before_adding_adapter branch August 7, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants