Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 996 add reports to s3 #173

Merged
merged 70 commits into from
Aug 22, 2023
Merged

Feature/sg 996 add reports to s3 #173

merged 70 commits into from
Aug 22, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Aug 7, 2023 •
edited
Loading

This PR includes

  • Scripts to automatically reproduce the reports. This is not meant for common use, only for the dev team to regenerate new reports when wanted.
  • Adding classmethods to instantiate AnalysisManager quickly which simplifies the code. Not mandatory for the PR but I think it's a good opportunity

Louis-Dupont and others added 30 commits June 29, 2023 13:32
@Louis-Dupont
first draft
22791d8
@Louis-Dupont
first draft
731d109
@Louis-Dupont
add voc
f265ecd
@Louis-Dupont
messy
373569e
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_detection
a3239e9
@Louis-Dupont
add doc
9925e2d
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
8dbbb73
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
009d97f
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
e71a102
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
244f0ac
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
4bd16fb
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
2e52efd
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_detection
f9386a1
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
ed07ac6
@Louis-Dupont
wip
d9af6c9
@Louis-Dupont
fix segmentation onehot
7fab76a
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
9fc5431
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_detection
ecda3d9
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
9e4b2ee
@Louis-Dupont
remove unwanted changed
75a175e
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
003b842
@Louis-Dupont
ad ddoc
937da6c
@BloodAxe
Merge branch 'master' into feature/SG-953-add_coco_detection
b84a9bf
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
93c6934
@Louis-Dupont
add test
2824efc
@Louis-Dupont
add test batch
7208a95
@Louis-Dupont
Merge branch 'master' into feature/SG-953-add_coco_segmentation
29ef565
@ofrimasad @Louis-Dupont
fixed empty page bug (#153)
d29c8ee 
added course link
@ofrimasad @Louis-Dupont
fixed link in pdf (#154)
9e65e01 
added a print in the terminal
@ofrimasad @Louis-Dupont
Feature/dg 000 add to readme (#155)
db34efc 
* add colab and discord to readme

* add colab and discord to readme

* fix image links
@Louis-Dupont Louis-Dupont marked this pull request as draft August 7, 2023 09:45
@Louis-Dupont Louis-Dupont marked this pull request as ready for review August 8, 2023 06:56
ofrimasad
ofrimasad reviewed Aug 13, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit weird to me...
why not use the from_x methods to generate a dataset and then pass that to a manager?
why did you decide to create a different manager by calling from_x?

@Louis-Dupont
Copy link
Contributor Author

This is a bit weird to me... why not use the from_x methods to generate a dataset and then pass that to a manager? why did you decide to create a different manager by calling from_x?

Renamed to analyze_x

BloodAxe
BloodAxe approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 59aca30 into master Aug 22, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-996-add_reports_to_s3 branch August 22, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad left review comments

@BloodAxe BloodAxe BloodAxe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Louis-Dupont @BloodAxe @ofrimasad @shaydeci