Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 845 add dataconfig with cache #93

Merged
merged 53 commits into from
Jun 21, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Jun 14, 2023

Change to colors and prints
f1d4112
image


I also added colors for other questions:
5c01ff6
image

@Louis-Dupont Louis-Dupont marked this pull request as ready for review June 18, 2023 14:58
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great.
some comment inline

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 724bbb4 into master Jun 21, 2023
@ofrimasad ofrimasad deleted the feature/SG-845-add-dataconfig-with-cache branch June 21, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants