Fix deprecated usage of pycocotools #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcakyon
requested review from
shaydeci,
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
ofrimasad
approved these changes
May 24, 2023
geoffrey-g-delhomme
pushed a commit
to geoffrey-g-delhomme/super-gradients
that referenced
this pull request
May 26, 2023
Co-authored-by: Ofri Masad <ofrimasad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great repo! We currently support sliced inference for Deci-AI models in SAHI!
However, super-gradients is using a deprecated version of pycocotools which is not supported by recent numpy [source].
This is failing our package: https://github.com/obss/sahi/actions/runs/4986890343/jobs/8928132617
This PR solves this issue by updating pycocotools to latest 💯