Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predict() support for pose estimation models #1142

Merged
merged 23 commits into from
Jun 11, 2023
Merged

predict() support for pose estimation models #1142

merged 23 commits into from
Jun 11, 2023

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Jun 6, 2023 •
edited
Loading 

from super_gradients.common.object_names import Models
from super_gradients.training import models
from super_gradients.training.models import DEKRPoseEstimationModel

dekr: DEKRPoseEstimationModel = models.get(Models.DEKR_W32_NO_DC, pretrained_weights="coco_pose")
result = dekr.predict("Football-2.jpeg", conf=0.2)
result.show(keypoint_radius=8, joint_thickness=4)

pred_0

@BloodAxe BloodAxe marked this pull request as ready for review June 7, 2023 09:08
@BloodAxe BloodAxe changed the title [WIP] predict() support for pose estimation models predict() support for pose estimation models Jun 7, 2023
ofrimasad
ofrimasad reviewed Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments and questions.
Are the colors defined here related to something? can't we just use some kind of colo-map?

src/super_gradients/recipes/dataset_params/coco_pose_estimation_dataset_params.yaml Outdated Show resolved Hide resolved
src/super_gradients/recipes/dataset_params/coco_pose_estimation_dataset_params.yaml Show resolved Hide resolved
src/super_gradients/training/models/pose_estimation_models/dekr_hrnet.py Show resolved Hide resolved
src/super_gradients/training/models/pose_estimation_models/dekr_hrnet.py Show resolved Hide resolved
src/super_gradients/training/models/prediction_pose_estimation_results.py Outdated Show resolved Hide resolved
src/super_gradients/training/models/prediction_pose_estimation_results.py Outdated Show resolved Hide resolved
src/super_gradients/training/models/predictions.py Outdated Show resolved Hide resolved
src/super_gradients/training/utils/visualization/poses.py Outdated Show resolved Hide resolved
@BloodAxe BloodAxe requested a review from shaydeci June 9, 2023 11:39
@BloodAxe
_pad_image cannot work with pad_value that is tuple (r,g,b).
02d1931 
So we change the keypoint transforms defaults in config to use single scalar value
@BloodAxe BloodAxe mentioned this pull request Jun 11, 2023
Closed
shaydeci
shaydeci approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit a43cfcd into master Jun 11, 2023
@BloodAxe BloodAxe deleted the feature/SG-910-predict-for-pose branch June 11, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad left review comments

@shaydeci shaydeci shaydeci approved these changes

@Louis-Dupont Louis-Dupont Awaiting requested review from Louis-Dupont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BloodAxe @ofrimasad @shaydeci