Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing encoding #1175

Closed
wants to merge 2 commits into from
Closed

Fix missing encoding #1175

wants to merge 2 commits into from

Conversation

allankouidri
Copy link
Contributor

Louis-Dupont
Louis-Dupont approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BloodAxe
BloodAxe approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe
Copy link
Contributor

@allankouidri it looks like your PR contains unsigned commits. Can you please redo the PR with signed commits? This is a strict requirement and I'm afraid this is blocker for us.
See https://github.com/Deci-AI/super-gradients/blob/master/CONTRIBUTING.md for instructions how to set it up.

This was referenced Jun 16, 2023
Closed
Closed
@allankouidri allankouidri deleted the hotfix/SG-fix_missing_encoding branch June 16, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont approved these changes

@BloodAxe BloodAxe BloodAxe approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allankouidri @BloodAxe @Louis-Dupont