-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sg 858 ignore multiple labels segmentation metrics support #1177
Merged
shaydeci
merged 15 commits into
master
from
feature/SG-858_ignore_multiple_labels_segmentation_metrics_support
Jun 20, 2023
Merged
Feature/sg 858 ignore multiple labels segmentation metrics support #1177
shaydeci
merged 15 commits into
master
from
feature/SG-858_ignore_multiple_labels_segmentation_metrics_support
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaydeci
requested review from
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
June 15, 2023 16:55
BloodAxe
reviewed
Jun 15, 2023
BloodAxe
reviewed
Jun 15, 2023
BloodAxe
reviewed
Jun 15, 2023
BloodAxe
reviewed
Jun 15, 2023
BloodAxe
reviewed
Jun 15, 2023
…abels_segmentation_metrics_support' into feature/SG-858_ignore_multiple_labels_segmentation_metrics_support
BloodAxe
reviewed
Jun 19, 2023
BloodAxe
reviewed
Jun 19, 2023
BloodAxe
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…entation_metrics_support
…entation_metrics_support
shaydeci
deleted the
feature/SG-858_ignore_multiple_labels_segmentation_metrics_support
branch
June 20, 2023 06:41
LHBuilder
pushed a commit
to LHBuilder/YOLO-NAS
that referenced
this pull request
Jun 25, 2023
…eci-AI#1177) * added unit tests * finalized unit tests * updated docs and test suite * updated docs * updated update() * updated update() test * renamed var in _handle_multiple_ignored_inds * faster index mapping for pixel accuracy * faster index mapping for pixel accuracy fix * fixed non inplace op in pixel accuracy * type checking for ignore index expanded to iterable --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> Co-authored-by: Ofri Masad <ofrimasad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option for multiple ignored indices for our segmentation metrics + unit tests.