-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sg 946 simpify torch schedulers integration #1230
Merged
ofrimasad
merged 13 commits into
master
from
feature/SG-946_simpligy_torch_schedulers_integration
Jul 5, 2023
Merged
Feature/sg 946 simpify torch schedulers integration #1230
ofrimasad
merged 13 commits into
master
from
feature/SG-946_simpligy_torch_schedulers_integration
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ligy_torch_schedulers_integration
BloodAxe
reviewed
Jun 29, 2023
BloodAxe
reviewed
Jun 29, 2023
BloodAxe
reviewed
Jun 29, 2023
BloodAxe
reviewed
Jun 29, 2023
BloodAxe
reviewed
Jun 29, 2023
…hedulers_integration' into feature/SG-946_simpligy_torch_schedulers_integration
BloodAxe
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Louis-Dupont
pushed a commit
that referenced
this pull request
Jul 5, 2023
* test added * docs added and cleanup * docs finalized * added unit test to suite * added unit tests for all schedulers * added warning for update_param_groups * added clarification for phase arg * refactored unt test --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
shaydeci
added a commit
that referenced
this pull request
Jul 10, 2023
* first draft * improve text * fix * remove unwanted code * wip * wip * add example * remove unwanted change: * improve display * add test * remove unwanted change * add typing for mettrics * undo unwanted change * work with dict * add tests * Feature/sg 946 simpify torch schedulers integration (#1230) * test added * docs added and cleanup * docs finalized * added unit test to suite * added unit tests for all schedulers * added warning for update_param_groups * added clarification for phase arg * refactored unt test --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> * add . * add run_test_freq * fix * add optional * fix --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.