Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved exceptions from training #1260

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

shaydeci
Copy link
Contributor

@shaydeci shaydeci commented Jul 10, 2023

Had a circular import issue when tried to introduce new exception + crash tip.
Exceptions should be in common, not training,

@shaydeci shaydeci marked this pull request as ready for review July 10, 2023 13:43
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit f4a0d9e into master Jul 14, 2023
@BloodAxe BloodAxe deleted the feature/SG-000_move_exceptions_to_common branch July 14, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants