Fix class_inclusion_list in DetectionDataset #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Dupont
requested review from
shaydeci,
ofrimasad and
BloodAxe
as code owners
|
Can you please leave a few words what this fix fixes and why it is done the way it is done? |
BloodAxe
reviewed
Jul 31, 2023
src/super_gradients/training/datasets/detection_datasets/detection_dataset.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is currently a bug where subclassing does not work when the input
target_formatis ConcatenatedTensorFormat.The root cause of this is that the tests were not updated when
ConcatenatedTensorFormatwas introduced to this dataset, so the code still pass with old deprecated format, but we did not detect that it doesnt work with the new format.