Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 901 extreme batch visualization for object detection #1339

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Feature/sg 901 extreme batch visualization for object detection #1339

merged 3 commits into from
Aug 7, 2023

Conversation

shaydeci
Copy link
Contributor

@shaydeci shaydeci commented Aug 3, 2023 •
edited
Loading

Screen Shot 2023-08-03 at 15 22 00

@shaydeci shaydeci marked this pull request as ready for review August 3, 2023 12:17
@shaydeci shaydeci changed the title Feature/sg 901 extreme batches viz od final Feature/sg 901 extreme batch visualization for object detection Aug 3, 2023
Louis-Dupont
Louis-Dupont reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor in-line comments

src/super_gradients/recipes/roboflow_yolo_nas_s.yaml Outdated Show resolved Hide resolved
src/super_gradients/training/utils/callbacks/callbacks.py Outdated Show resolved Hide resolved
src/super_gradients/training/utils/callbacks/callbacks.py Show resolved Hide resolved
@BloodAxe
Copy link
Contributor

BloodAxe commented Aug 4, 2023

What would happen if I add two callbacks to visualize best and worst batch based on observed metric? Would everything work fine or they would overwrite each other? In other words - does tag value for logged images respect the max argument?

@shaydeci
Copy link
Contributor Author

shaydeci commented Aug 6, 2023

What would happen if I add two callbacks to visualize best and worst batch based on observed metric? Would everything work fine or they would overwrite each other? In other words - does tag value for logged images respect the max argument?

It will.

Screen Shot 2023-08-06 at 11 24 19

Louis-Dupont
Louis-Dupont reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit e6baa8a into master Aug 7, 2023
@shaydeci shaydeci deleted the feature/SG-901_extreme_batches_viz_od_final branch August 7, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont left review comments

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@BloodAxe BloodAxe Awaiting requested review from BloodAxe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaydeci @BloodAxe @Louis-Dupont