Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Exception when metric_to_watch is wrong #1437

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Improve Exception when metric_to_watch is wrong #1437

merged 4 commits into from
Aug 31, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Aug 31, 2023 •
edited
Loading

Example:

metric_to_watch: Accurac # `y` is missing
valid_metrics_list:
  - Accuracy
  - Top5

What we currently get in master

    return fuzzy_list.index(fuzzy_name)
ValueError: 'accurac' is not in list

What we will get after this PR

ValueError: No match found for `metric_to_watch=Accurac`. It should be one of ['LabelSmoothingCrossEntropyLoss', 'Accuracy', 'Top5'].

BloodAxe
BloodAxe approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 1964250 into master Aug 31, 2023
@Louis-Dupont Louis-Dupont deleted the hotfix/SG-000-improve_metric_to_watch_indexerror branch August 31, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Louis-Dupont @BloodAxe