-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce sample-centric keypoint transforms #1492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick overview of the code. It looks great, for now I only have notes on documentation.
I will go over it later, now that I better understand the changes.
src/super_gradients/training/transforms/keypoints/abstract_keypoints_transform.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_compose.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_compose.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_compose.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_image_normalize.py
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_random_affine.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_random_affine.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_random_affine.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_random_horisontal_flip.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_rescale.py
Outdated
Show resolved
Hide resolved
src/super_gradients/recipes/dataset_params/coco_pose_estimation_dataset_params.yaml
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_image_standardize.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_mixup.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_mosaic.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_mosaic.py
Outdated
Show resolved
Hide resolved
…lease' into feature/SG-1060-yolo-nas-pose-release
# Conflicts: # src/super_gradients/recipes/dataset_params/coco_pose_estimation_dataset_params.yaml
…1506) * Cherry pick changes to post-prediction, visualization and metric * Remove unwanted references to new datasets * Remove YoloNASPoseCollateFN * Fixed unit test * Improve clarify of bbox format by giving it more explicit name and added a bunch of docstrings * Improve variable names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
PoseEstimationSample
that holds all information about a single dataset samplePoseEstimationSample
as well as existing API that pass a tuple (image
,mask
,boxes
,...)paths are still working fine.
New transforms:
Sanity checks:
We can merge this PR as is to master or we can 'fake approve' this PR (If everyone is good with the concept) and I will keep adding yolo-nas pose stuff on top of it (Through PR to this branch)