Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sample-centric keypoint transforms #1492

Merged
merged 21 commits into from
Oct 11, 2023

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Oct 2, 2023

What this PR does:

  • Introduce PoseEstimationSample that holds all information about a single dataset sample
  • Refactor all existing transforms (and add a bunch of new ones) for pose estimation that enables then to work with new PoseEstimationSample as well as existing API that pass a tuple (image,mask,boxes,...)
  • Move each transform to a single file (Just to make editing / navigating a little easier). Old import
    paths are still working fine.

New transforms:

  • Random 90-degree rotation
  • Mixup
  • Mosaic
  • Brightness/Contrast
  • Rescale to fixed size (Non-preserving aspect ratio)

Sanity checks:

  • Existing DEKR recipe still works as expected. No API change on the user level
  • New & existing transforms tested extensively during YoloNASPose training

We can merge this PR as is to master or we can 'fake approve' this PR (If everyone is good with the concept) and I will keep adding yolo-nas pose stuff on top of it (Through PR to this branch)

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick overview of the code. It looks great, for now I only have notes on documentation.

I will go over it later, now that I better understand the changes.

Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 06038a2 into master Oct 11, 2023
@BloodAxe BloodAxe deleted the feature/SG-1060-yolo-nas-pose-release branch October 11, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants