Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A call to _process_collate_fn_params was missing in dataloaders.get. #1501

Merged
merged 1 commit into from
Oct 5, 2023
Merged

A call to _process_collate_fn_params was missing in dataloaders.get. #1501

merged 1 commit into from
Oct 5, 2023

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Oct 5, 2023

Otherwise string collate FN would not be instantiated properly IF dataloader name is None and dataset name is present in dataloader params

@BloodAxe
A call to _process_collate_fn_params was missing in dataloaders.get.
265c893 
Otherwise string collate FN would not be instantiated properly IF dataloader name is None and dataset name is present in dataloader params
Louis-Dupont
Louis-Dupont approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 8637ee7 into master Oct 5, 2023
2 checks passed
@BloodAxe BloodAxe deleted the hotfix/SG-000-fix-process_collate_fn branch October 5, 2023 10:26
BloodAxe added a commit that referenced this pull request Oct 5, 2023
@BloodAxe
A call to _process_collate_fn_params was missing in dataloaders.get. (#…
82f26f8 
…1501)

Otherwise string collate FN would not be instantiated properly IF dataloader name is None and dataset name is present in dataloader params

(cherry picked from commit 8637ee7)
@BloodAxe BloodAxe mentioned this pull request Oct 5, 2023
Merged
BloodAxe added a commit that referenced this pull request Oct 5, 2023
@BloodAxe
A call to _process_collate_fn_params was missing in dataloaders.get. (#…
a762a4d 
…1501) (#1502)

Otherwise string collate FN would not be instantiated properly IF dataloader name is None and dataset name is present in dataloader params

(cherry picked from commit 8637ee7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BloodAxe @Louis-Dupont