-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squashed changes with YoloNASPose & Loss #1512
Merged
BloodAxe
merged 41 commits into
master
from
feature/SG-1060-yolo-nas-pose-release-add-model-and-loss
Oct 13, 2023
Merged
Squashed changes with YoloNASPose & Loss #1512
BloodAxe
merged 41 commits into
master
from
feature/SG-1060-yolo-nas-pose-release-add-model-and-loss
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lease' into feature/SG-1060-yolo-nas-pose-release
# Conflicts: # src/super_gradients/recipes/dataset_params/coco_pose_estimation_dataset_params.yaml
…1506) * Cherry pick changes to post-prediction, visualization and metric * Remove unwanted references to new datasets * Remove YoloNASPoseCollateFN * Fixed unit test * Improve clarify of bbox format by giving it more explicit name and added a bunch of docstrings * Improve variable names
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
October 9, 2023 12:42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some comments, but I'm still reviewing
src/super_gradients/module_interfaces/exportable_pose_estimation.py
Outdated
Show resolved
Hide resolved
...r_gradients/training/models/pose_estimation_models/yolo_nas_pose/yolo_nas_pose_ndfl_heads.py
Outdated
Show resolved
Hide resolved
...r_gradients/training/models/pose_estimation_models/yolo_nas_pose/yolo_nas_pose_ndfl_heads.py
Show resolved
Hide resolved
...r_gradients/training/models/pose_estimation_models/yolo_nas_pose/yolo_nas_pose_ndfl_heads.py
Outdated
Show resolved
Hide resolved
...r_gradients/training/models/pose_estimation_models/yolo_nas_pose/yolo_nas_pose_ndfl_heads.py
Outdated
Show resolved
Hide resolved
...per_gradients/training/models/pose_estimation_models/yolo_nas_pose/yolo_nas_pose_variants.py
Show resolved
Hide resolved
Base automatically changed from
feature/SG-1060-yolo-nas-pose-release
to
master
October 11, 2023 07:16
…follow and update
Louis-Dupont
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BloodAxe
deleted the
feature/SG-1060-yolo-nas-pose-release-add-model-and-loss
branch
October 13, 2023 08:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following components of YoloNASPose