Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to utils #1513

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Small improvements to utils #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
072b986
Small improvements to utils
BloodAxe Oct 9, 2023
d627726
Merge branch 'master' into feature/SG-000-small-improvements-to-uilts
BloodAxe Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/super_gradients/training/utils/distributed_training_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,8 @@ def maybe_all_reduce_tensor_average(tensor: torch.Tensor) -> torch.Tensor:
:return:
"""
if is_distributed():
tensor = distributed_all_reduce_tensor_average(tensor=tensor, n=torch.distributed.get_world_size())
# .to_dense() is required to ensure we can do maybe_all_reduce_tensor_average(some_vector[3])
tensor = distributed_all_reduce_tensor_average(tensor=tensor.to_dense(), n=torch.distributed.get_world_size())
return tensor


Expand Down
9 changes: 6 additions & 3 deletions src/super_gradients/training/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,12 @@ def convert_to_tensor(array, dtype=None, device=None):
:param array: torch.tensor / Numpy array / List
"""
if not torch.is_tensor(array):
array = torch.tensor(array)

return array.to(device=device, dtype=dtype)
if isinstance(array, np.ndarray):
return torch.from_numpy(array).to(device=device, dtype=dtype)
else:
return torch.tensor(array, device=device, dtype=dtype)
else:
return array.to(device=device, dtype=dtype)


class HpmStruct:
Expand Down