Ensure that checkpoint_num_classes is propagated from YAML to model
#1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
Louis-Dupont
pushed a commit
that referenced
this pull request
Oct 17, 2023
…#1533) * Ensure that `checkpoint_num_classes` is propagated from YAML to models.get() * Red checkpoint_num_classes via get_params
Louis-Dupont
added a commit
that referenced
this pull request
Oct 17, 2023
* first draft * fix * fix * fix detectiondataset * Ensure that `checkpoint_num_classes` is propagated from YAML to model (#1533) * Ensure that `checkpoint_num_classes` is propagated from YAML to models.get() * Red checkpoint_num_classes via get_params * Fixed a bug in export() that prevented to export model for BS>1 (#1530) * Remove unnecessary files (#1540) * remove check on base class --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Louis-Dupont
added a commit
that referenced
this pull request
Oct 17, 2023
* first draft * fix * fix * fix detectiondataset * Ensure that `checkpoint_num_classes` is propagated from YAML to model (#1533) * Ensure that `checkpoint_num_classes` is propagated from YAML to models.get() * Red checkpoint_num_classes via get_params * Fixed a bug in export() that prevented to export model for BS>1 (#1530) * Remove unnecessary files (#1540) * remove check on base class --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Louis-Dupont
added a commit
that referenced
this pull request
Oct 18, 2023
* first draft * fix * fix * fix detectiondataset * Ensure that `checkpoint_num_classes` is propagated from YAML to model (#1533) * Ensure that `checkpoint_num_classes` is propagated from YAML to models.get() * Red checkpoint_num_classes via get_params * Fixed a bug in export() that prevented to export model for BS>1 (#1530) * Remove unnecessary files (#1540) * remove check on base class --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that
checkpoint_num_classescannot be set through YAML file:Use case: Downloaded pre-trained checkpoint from sghub locally and want to train a model with 1 class instead of 80. Since it's local checkpoint, not using
pretrain_weightsbutcheckpoint_path. In this case must specifycheckpoint_num_classesbut it is not propagated properly.