Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 000 proparage fixes from master #1577

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Feature/sg 000 proparage fixes from master #1577

merged 9 commits into from
Oct 26, 2023

Conversation

BloodAxe
Copy link
Contributor

Proparage bugfixes from master

  • Fixes for model export
  • Fixes for AMP & no CUDA
  • Fixes for torch 1.12
  • Fix in Makefile

hakuryuu96 and others added 9 commits October 26, 2023 12:14
@hakuryuu96 @BloodAxe
[Improvement] max_batches support to training log and tqdm progress b…
28184d3 
…ar. (#1554)

* Added max_batches support to training log and tqdm progress bar.

* Added changing string in accordance which parameter is used (len(loader) of max_batches)

* Replaced stopping condition for the epoch with a smaller one

(cherry picked from commit 749a9c7)
@Louis-Dupont @BloodAxe
fix (#1558)
5879c46 
Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
(cherry picked from commit 8a1d255)
@Louis-Dupont @BloodAxe
fix (#1564)
d2d9c18 
(cherry picked from commit 24798b0)
@BloodAxe
Bugfix of model.export() to work correct with bs>1 (#1551)
458787a 
(cherry picked from commit 0515496)
@BloodAxe
Fixed incorrect automatic variable used (#1565)
693c7b5 
$@ is the name of the target being generated, and $^ are the dependencies

Co-authored-by: Louis-Dupont <35190946+Louis-Dupont@users.noreply.github.com>
(cherry picked from commit 43f8bea)
@aler9 @BloodAxe
fix typo in class documentation (#1548)
a587262 
Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Co-authored-by: Louis-Dupont <35190946+Louis-Dupont@users.noreply.github.com>
(cherry picked from commit ec21383)
@Louis-Dupont @BloodAxe
Feature/sg 1198 mixed precision automatically changed with warning (#…
7e017d0 
…1567)

* fix

* work with tmpdir

* minor change of comment

* improve device_config

(cherry picked from commit 34fda6c)
@BloodAxe
Fixed issue with torch 1.12 where _scale_fn_ref is missing in CyclicLR (
237f552 
#1575)

(cherry picked from commit 23b4f7a)
@BloodAxe
Fixed issue with torch 1.12 issue with arange not supporting fp16 for…
75bbc87 
… CPU device. (#1574)

(cherry picked from commit 1f15c76)
Louis-Dupont
Louis-Dupont approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit e8a51d3 into master_330 Oct 26, 2023
1 check passed
@BloodAxe BloodAxe deleted the feature/SG-000-proparage-fixes-from-master branch October 26, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BloodAxe @Louis-Dupont @hakuryuu96 @aler9