Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated "What are Recipes and How To Use Them" notebook #1586

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Updated "What are Recipes and How To Use Them" notebook #1586

merged 4 commits into from
Oct 30, 2023

Conversation

BloodAxe
Copy link
Contributor

No description provided.

shaydeci
shaydeci suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two things:

  1. Shouldn't we update Makefile to include the notebook docs (run_and_convert_notebooks_to_docs)?
  2. Please use pip install XXX &> /dev/null or drop output so we don't trash notebook output.

@BloodAxe
Copy link
Contributor Author

Looks good. Just two things:

  1. Shouldn't we update Makefile to include the notebook docs (run_and_convert_notebooks_to_docs)?
  2. Please use pip install XXX &> /dev/null or drop output so we don't trash notebook output.

Fixed in 60c244b
Thanks for suggestions

shaydeci
shaydeci approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit b71abd6 into master Oct 30, 2023
3 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1189-update-notebooks branch October 30, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@Louis-Dupont Louis-Dupont Awaiting requested review from Louis-Dupont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BloodAxe @shaydeci