Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KD Notebook for classification #1595

Merged
merged 15 commits into from
Nov 5, 2023
Merged

Update KD Notebook for classification #1595

merged 15 commits into from
Nov 5, 2023

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Oct 31, 2023 •
edited
Loading

This PR update KD Notebook and fixes a few bugs related:

  1. A predict() was not possible to use with KDTrainer (dataset preprocessing params were not properly set)
  2. Resize implementation for classification was implemented wrong (Not as it works in torchvision)
  3. Extracting preprocessing transforms from torchvision transforms were not implemented

shaydeci
shaydeci suggested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single comment inline.

Louis-Dupont
Louis-Dupont reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already, I just have a small test sugestion

@BloodAxe BloodAxe requested a review from shaydeci November 1, 2023 14:55
shaydeci
shaydeci previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ofrimasad
ofrimasad approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 885e2f0 into master Nov 5, 2023
@ofrimasad ofrimasad deleted the feature/SG-1189-update-notebooks branch November 5, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont left review comments

@ofrimasad ofrimasad ofrimasad approved these changes

@shaydeci shaydeci shaydeci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BloodAxe @ofrimasad @Louis-Dupont @shaydeci