Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate tight_box_rotation parameters in COCODetectionDataset #1786

Merged
merged 9 commits into from
Feb 6, 2024

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Jan 24, 2024

None of the recipes use this parameter.
Currently this parameter cannot be used anyway since we don't propagate segmentation masks to DetectionSample. Albumentations does not support this feature either.

@BloodAxe BloodAxe marked this pull request as ready for review January 24, 2024 14:50
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please implement a decorator for deprecated_argument
I though we already have it...

@BloodAxe BloodAxe mentioned this pull request Jan 25, 2024
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit d5a85fd into master Feb 6, 2024
7 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1333-remove-tight-box-rotation branch February 6, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants